stream: stream/iter node.js streams interop#62469
Open
jasnell wants to merge 3 commits intonodejs:mainfrom
Open
stream: stream/iter node.js streams interop#62469jasnell wants to merge 3 commits intonodejs:mainfrom
jasnell wants to merge 3 commits intonodejs:mainfrom
Conversation
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus 4.6
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus 4.6
Signed-off-by: James M Snell <jasnell@gmail.com> Assisted-by: Opencode/Opus 4.6
jasnell
added
stream
Collaborator
|
Review requested:
|
nodejs-github-bot
added
lib / src
jasnell
changed the title
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #62469 +/- ##
==========================================
+ Coverage 89.70% 89.71% +0.01%
==========================================
Files 691 691
Lines 213935 214701 +766
Branches 41050 41218 +168
==========================================
+ Hits 191907 192619 +712
- Misses 14095 14146 +51
- Partials 7933 7936 +3
🚀 New features to boost your workflow:
|
Collaborator
Collaborator
Collaborator
guybedford
reviewed
Mar 30, 2026
| * from() will return such sources directly, skipping all normalization. | ||
| * This is NOT a public protocol symbol - it uses Symbol() not Symbol.for(). | ||
| */ | ||
| const kTrustedSource = Symbol('kTrustedSource'); |
Contributor
There was a problem hiding this comment.
Trusted seems the wrong name here if it is exported for use in arbitrary userland contracts.
For trusted I'd have assumed only hosts could generate these types say.
Perhaps use the term "valid" instead, something like kValidBufferSource?
mcollina
requested changes
Mar 31, 2026
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
I would prefer if these utilities to be exposed only in the new iter module as a function utilities instead of attaching them to the node stream
prototype
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementing prototype integration points for experimental stream/iter and node.js stream.Readable/stream.Writable
Signed-off-by: James M Snell jasnell@gmail.com
Assisted-by: Opencode/Opus 4.6